parsecsv fix style #17933
Merged
parsecsv fix style #17933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 4, 2021
lib/pure/parsecsv.nim
Outdated
| @@ -97,10 +96,10 @@ proc raiseEInvalidCsv(filename: string, line, col: int, | |||
| e.msg = filename & "(" & $line & ", " & $col & ") Error: " & msg | |||
| raise e | |||
|
|
|||
| proc error(my: CsvParser, pos: int, msg: string) = | |||
| raiseEInvalidCsv(my.filename, my.lineNumber, getColNumber(my, pos), msg) | |||
| proc error(self: CsvParser, pos: int, msg: string) {.inline.} = | |||
There was a problem hiding this comment.
You said that there was no logic change, yet you introduced {.inline.} here?
There was a problem hiding this comment.
Don't inline code that is off the critical path... Don't make error handling super fast, most of the time there is no error.
ghost
reviewed
May 4, 2021
Araq
reviewed
May 4, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* ReSync with Devel * Fix style in parsecsv * Update lib/pure/parsecsv.nim Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parsecsvfix style, was using "my" instead ofself, no logic change.