Expand --nimMainPrefix semantics
#19950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand `--nimMainPrefix` semantics to include prefixing these symbols for the C, C++ and ObjC backends: * `cmdCount` * `cmdLine` * `gEnv` * `PreMain` * `PreMainInner` * `NimMainInner` * `NimMainModule` Fixes nim-lang#15955 Fixes nim-lang#19830
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand
--nimMainPrefixsemantics to include prefixing these symbolsfor the C, C++ and ObjC backends:
cmdCountcmdLinegEnvPreMainPreMainInnerNimMainInnerNimMainModuleFixes #15955
Fixes #19830
PR State
I hadn't noticed #19934 before I made this to resolve some issues I had making some tests for #19925. I made a PR in haste and committed a merge conflict in my rush :(.
I have noticed that #19934 doesn't prefix
gEnv,cmdCount, orcmdLine. I will update this PR to just handle those and add some tests. I'm currently running some tests on various platforms to understand the symbol visibility for the various platforms and backends.