Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tests into a larger file (part 7 of ∞: misc) #9495

Closed
wants to merge 2 commits into from

Conversation

narimiran
Copy link
Member

As usual:

  • issues are grouped in tissues.nim
  • various small tests are grouped in tmisc.nim

@narimiran narimiran closed this Oct 25, 2018
@narimiran narimiran reopened this Oct 25, 2018
@Araq Araq closed this Oct 25, 2018
@Araq Araq reopened this Oct 25, 2018
@genotrance
Copy link
Contributor

Note that tissues.nim, tmisc.nim are not unique names and considering testament runs things in parallel, it is hard to tell from the logs which instance actually failed. You might want to include the category name in the filename for clarity.

@narimiran
Copy link
Member Author

Note that tissues.nim, tmisc.nim are not unique names and considering testament runs things in parallel, it is hard to tell from the logs which instance actually failed.

Thanks for bringing my attention to this.

I'll fix all the tissues in some next PR by renaming them to t<folder_name>_issues.nim.


Regarding failing CI: I don't know why are they failing again (but Travis on OSX passes). I'll restart them once again.

@genotrance
Copy link
Contributor

Meh, on second thought, would have been easier to update testament to print out category but that's a more drastic change.

@narimiran
Copy link
Member Author

@Araq can you please see what is going on with the tests?

I've rebased against devel, but once again AppVeyor raises the same error as before, and from what I can tell it doesn't have to do anything with the files changed here.

I get the same AppVeyor error in my other PR, and it is the same error @dom96 got here.

@narimiran
Copy link
Member Author

This PR is jinxed.

No matter how many times I restart tests, the results are always the same: passing on Mac, failing on Linux and Windows at some point unrelated to this PR. For what is worth, when I locally do koch test cat misc everything is passing (on Linux).

@Araq
Copy link
Member

Araq commented Nov 10, 2018

Yeah but as @timotheecour pointed out, it's better to let the tests be small and change testament to merge tests of a single category if possible. We will do this instead.

@Araq Araq closed this Nov 10, 2018
@timotheecour
Copy link
Member

for reference: #9581

@narimiran narimiran deleted the tests-part7 branch November 17, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants