-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge tests into a larger file (part 7 of ∞: misc) #9495
Conversation
Note that tissues.nim, tmisc.nim are not unique names and considering testament runs things in parallel, it is hard to tell from the logs which instance actually failed. You might want to include the category name in the filename for clarity. |
Thanks for bringing my attention to this. I'll fix all the Regarding failing CI: I don't know why are they failing again (but Travis on OSX passes). I'll restart them once again. |
eddf9bc
to
d7e37d5
Compare
Meh, on second thought, would have been easier to update testament to print out category but that's a more drastic change. |
@Araq can you please see what is going on with the tests? I've rebased against devel, but once again AppVeyor raises the same error as before, and from what I can tell it doesn't have to do anything with the files changed here. I get the same AppVeyor error in my other PR, and it is the same error @dom96 got here. |
2f3a469
to
facdabc
Compare
facdabc
to
0985df1
Compare
This PR is jinxed. No matter how many times I restart tests, the results are always the same: passing on Mac, failing on Linux and Windows at some point unrelated to this PR. For what is worth, when I locally do |
Yeah but as @timotheecour pointed out, it's better to let the tests be small and change testament to merge tests of a single category if possible. We will do this instead. |
for reference: #9581 |
As usual:
tissues.nim
tmisc.nim