Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive names of test files #9531

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Conversation

narimiran
Copy link
Member

As noted here:

Note that tissues.nim, tmisc.nim are not unique names and considering testament runs things in parallel, it is hard to tell from the logs which instance actually failed. You might want to include the category name in the filename for clarity.

@Araq
Copy link
Member

Araq commented Oct 29, 2018

I love your work.

@Araq Araq merged commit 1b17c9f into nim-lang:devel Oct 29, 2018
@timotheecour
Copy link
Member

@narimiran

it is hard to tell from the logs which instance actually failed

can we make testament print relative path of files being tested, eg:
instead of printing
foo.nim
print:
tests/concepts/foo.nim
(or at least: concepts/foo.nim but I prefer strongly the former)

ianmcxa pushed a commit to ianmcxa/Nim that referenced this pull request Oct 30, 2018
* change generic `tissues` name to more specific
* change `tvarious` to more specific names
narimiran added a commit to narimiran/Nim that referenced this pull request Oct 31, 2018
* change generic `tissues` name to more specific
* change `tvarious` to more specific names
@narimiran narimiran deleted the tests-rename branch November 12, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants