Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression caused by caseStmtMacros: match=>case #73

Merged

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 19, 2021

this should fix the recent regression caused by nim-lang/Nim#16923 and unblock fusion in important_packages, refs nim-lang/Nim#17094

but after this PR we should fix caseStmtMacros to be implemented as macro customCase[T](a: T, b: CaseStmt): untyped = ..., as described in nim-lang/RFCs#332 (comment)

@ringabout
Copy link
Member

btw nim-lang/Nim#17047

@Araq Araq merged commit e0dfb9e into nim-lang:master Feb 19, 2021
@timotheecour timotheecour deleted the pr_fix_matching_regression_caseStmtMacros branch February 19, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants