Fix #76, #82, #83, update docs, more constistent opt <pattern> or <default> implementation
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The relevant issue is nim-lang/Nim#17199 by the way so this is a workaround I guess? |
This was referenced Mar 10, 2021
|
might not be needed if nim-lang/Nim#17348 works and will be merged |
|
Reverting this is a simple find-replace for |
- ADDED :: - implement `opt` for field access
- CHANGED :: Before calling check function on nested match element check using `isNil` if entry can is correct. This avoids almost unfixable nil-based exceptions triggered deeply within pattern.
- CHANGED ::
- Use more readable, unabreviated field names (cnt -> foundCount,
fldElems -> fieldElements)
Compiling /home/runner/work/fusion/fusion/fusion/tests/tmatching (from package fusion) using c backend
Error: /home/runner/work/fusion/fusion/nim/lib/std/private/underscored_calls.nim(43, 21) Error: 'nnkArgList' should be: 'nnkArglist'
Tip: 5 messages have been suppressed, use --verbose to show them.
|
Fix #83 |
haxscramper
changed the title
opt <pattern> or <default> implementation
haxscramper
changed the title
opt <pattern> or <default> implementationopt <pattern> or <default> implementation
|
CI failure unrelated to |
|
CI failure unrelated - all the failures happened on "install dependencies" stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
--gc:{orc,arc}caused macro to behave differently, by somehow mutating immutable access path passed to the match expression generator. I wasn't able to reliably reproduce the bug, but it wasn't related to implementation itself.Fixed that by explicitly copying path each time it is passed around - usually it is a sequence of 3-4 access elements, and copying only happens during macro evaluation.
Related: #76