Run CI tests with arc/orc in addition to default GC #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/ci.yml
Outdated
| run: nimble test | ||
| run: | | ||
| nimble test | ||
| if [[ '${{ matrix.branch }}' != 'version-1-0' ]]; then |
There was a problem hiding this comment.
move this logic inside nim/nimble.
the less logic the pipeline does the better (eg for portability etc)
There was a problem hiding this comment.
I don't know how to do this - if I understand correctly matrix.branch is not an environment variable but a context that is substituted by GitHub CI.
Also, this would require writing a custom test target (which either checks for the environment somehow, or tries to determine the current version of the compiler and runs tests based on that).
There was a problem hiding this comment.
in fusion.nimble add this:
task testMulti, "":
# see also `testTask()` to call task `test`
exec "nimble test"
when (NimMajor, NimMinor) >= (1, 2):
exec "nimble test --gc:arc"
exec "nimble test --gc:orc"and here call nimble testMulti
that way, nim CI important_packages could (if it desired) call nimble testMulti to reuse the logic instead of re-implementing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all fusion tests pass with orc/arc enabled (with #77 pattern matching passes too), but I think it is necessary to also test compilation with non-default GC.