Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI using choosenim #877

Merged
merged 3 commits into from Nov 20, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/test.yml
@@ -0,0 +1,30 @@
on:
push:
pull_request:

jobs:
test:
strategy:
matrix:
os:
- windows-latest
- macos-latest
- ubuntu-latest
target:
- 0.20.2
- 1.0.10
- 1.2.8
- 1.4.0
- git:8a004e2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just a demo? :)

Pretty cool, but we don't need this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mimics the current Travis build: https://github.com/nim-lang/nimble/blob/master/.travis.yml#L13 I'm fine removing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it's either this or the nightly. We don't need both. If the nightly works and is newer let's keep it instead of this.

- nightly:https://github.com/nim-lang/nightlies/releases/tag/2020-11-11-devel-bbe49a14ae827b6474d692042406716a3b3dd71f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing choosenim is not used for this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. If there's a something: prefix, choosenim is not used.

name: ${{ matrix.os }} - ${{ matrix.target }}
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: iffy/install-nim@v3
- run: nim --version
- name: Run nim c -r tester
run: |
cd tests
nim c -r tester
- run: ./src/nimble install -y