Add project:serve-web #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rabbah
reviewed
Feb 2, 2021
src/commands/web/serve.ts
Outdated
| this.wrap(content, packLocation, logger, code, signal) | ||
| }) | ||
| } else { | ||
| const httpServer = spawn(`npx http-server --proxy ${proxy}`, { |
There was a problem hiding this comment.
Is there a programmatic interface to use instead? Is this better than an internal api? I don’t know which is better so simply asking.
There was a problem hiding this comment.
I think it's possible to do it using internal APIs or we might even add http-server as a dependency and use its APIs, let's get the user feedback first. I am keeping that avenue open for the next iteration.
joshuaauerbachwatson
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the web folder has
package.json, it proxies to the current/given namespace APIs and runsnpm startotherwise serves static content using 'npx http-server'links #45
Usage:
nim web servedefaults to the current project's web foldernim web serve /projects/nim/demo-projects/electionnim web serve /exp/ncovstats