Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearing down audio timeouts #39

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

0x1stvan
Copy link
Contributor

@0x1stvan 0x1stvan commented May 30, 2024

Clearing timeouts to fix audio distortions and dialogflow speak

More info here:
#37

@0x1stvan
Copy link
Contributor Author

Looks like it fixes it, but need more testing. I'm open for PR improvements.

@danjenkins
Copy link
Contributor

I'll take a proper look when I can, try not changing other things in the PR like whitespace etc... makes looking at it far easier. I know there are def things in there that need updating etc... but those should be in a separate PR :)

First glance it looks like that should work fine.

@0x1stvan
Copy link
Contributor Author

I'll take a proper look when I can, try not changing other things in the PR like whitespace etc... makes looking at it far easier. I know there are def things in there that need updating etc... but those should be in a separate PR :)

First glance it looks like that should work fine.

Working on to keep the original comments and format.

@0x1stvan
Copy link
Contributor Author

@danjenkins You can check the last commit, i keep the original code just added the changes. https://github.com/nimbleape/asterisk-dialogflow-rtp-audioserver/pull/39/files

@danjenkins
Copy link
Contributor

Looks good, I haven't tested it but I see no reason why this wouldn't work!

@danjenkins danjenkins merged commit 292b607 into nimbleape:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants