Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composables to have a Modifier parameter with default value #428

Closed
1 task
ryan-conway opened this issue Mar 7, 2023 · 0 comments · Fixed by #475
Closed
1 task

Update composables to have a Modifier parameter with default value #428

ryan-conway opened this issue Mar 7, 2023 · 0 comments · Fixed by #475
Assignees
@Wadeewee
Labels
priority : normal status : approved type : chore
Milestone
3.21.0

Comments

@ryan-conway
Copy link
Collaborator

Why

Original RFC

According to the API Guidelines for Jetpack Compose, composable elements must accept a parameter of type Modifier with a default value of Modifier.

Who Benefits?

Android developers

Acceptance Criteria

  • Update template-compose and sample-compose to add modifier: Modifier = Modifier to all composable functions that emit UI.
    • We do not need to add this to Preview composables.
@ryan-conway ryan-conway added this to the 3.19.0 milestone Mar 7, 2023
@ryan-conway ryan-conway changed the title Update Update composables to have a Modifier parameter with default value Mar 7, 2023
@ryan-conway ryan-conway modified the milestones: 3.19.0, 3.20.0 Apr 4, 2023
@ryan-conway ryan-conway modified the milestones: 3.20.0, 3.21.0 May 2, 2023
Wadeewee added a commit that referenced this issue Jun 15, 2023
@Wadeewee
[#428] Add modifier parameter
b7cddaa
Wadeewee added a commit that referenced this issue Jun 15, 2023
@Wadeewee
[#428] Add modifier parameter
2e19dbd
@Wadeewee Wadeewee mentioned this issue Jun 15, 2023
Merged
1 task
@Wadeewee Wadeewee linked a pull request Jun 15, 2023 that will close this issue
[#428] [Chore] Update composables to have a Modifier parameter with default value #475
Merged
1 task
ryan-conway added a commit that referenced this issue Jun 16, 2023
@ryan-conway
Merge pull request #475 from nimblehq/chore/428-add-modifier-paramete…
c196e80 
…r-with-default-value

[#428] [Chore] Update composables to have a Modifier parameter with default value
@ryan-conway ryan-conway mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wadeewee Wadeewee

Labels
priority : normal status : approved type : chore
Projects
None yet
Milestone
3.21.0
2 participants
@Wadeewee @ryan-conway