Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing additional use-cases mocking and tests verifying steps in CI for sample-xml & sample-compose #443

Closed
luongvo opened this issue Mar 16, 2023 · 0 comments · Fixed by #444
Closed

Fix: Missing additional use-cases mocking and tests verifying steps in CI for sample-xml & sample-compose #443

luongvo opened this issue Mar 16, 2023 · 0 comments · Fixed by #444
Assignees
@luongvo
Labels
priority : normal type : bug
Milestone
3.18.0

Comments

@luongvo
Copy link
Member

luongvo commented Mar 16, 2023 •
edited
Loading

Issue

We forgot to add necessary additional use-cases mocking in tests when working on the Support datastore replacing shared preference feature (#389, #407) for the sample-xml & sample-compose projects. This makes the tests unable to execute and blocks my current task #425.

Secondly, we're missing the tests verifying steps in CI from this workflow run_detekt_and_unit_tests.yml for the sample-xml & sample-compose projects, so we don't have ways to verify our updates.

Expected

The tests in the sample-xml & sample-compose projects should be able to execute and pass.

Steps to reproduce

  1. Run tests in the sample-xml or sample-compose project.
@luongvo luongvo added this to the 3.18.0 milestone Mar 16, 2023
@luongvo luongvo self-assigned this Mar 16, 2023
luongvo added a commit that referenced this issue Mar 16, 2023
@luongvo
[#443] Add more steps to verify the sample xml & compose projects bef…
9349f1b 
…ore updating the core logic
luongvo added a commit that referenced this issue Mar 16, 2023
@luongvo
[#443] Fix: missing UseCases setup & mocking in tests
f8040b5
@luongvo luongvo mentioned this issue Mar 16, 2023
Merged
@luongvo luongvo linked a pull request Mar 16, 2023 that will close this issue
[#443] Fix: Missing additional use-cases mocking and tests verifying steps in CI for sample-xml & sample-compose #444
Merged
ryan-conway added a commit that referenced this issue Mar 21, 2023
@ryan-conway
Merge pull request #444 from nimblehq/bug/443-add-missing-tests-verif…
0ef7892 
…ication-steps-in-ci-and-fix-failed-tests

[#443] Fix: Missing additional use-cases mocking and tests verifying steps in CI for sample-xml & sample-compose
@ryan-conway ryan-conway mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luongvo luongvo

Labels
priority : normal type : bug
Projects
None yet
Milestone
3.18.0
1 participant
@luongvo