Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup test #3

Merged
merged 12 commits into from
Aug 20, 2020
Merged

Setup test #3

merged 12 commits into from
Aug 20, 2020

Conversation

Tolsee
Copy link
Contributor

@Tolsee Tolsee commented Jun 10, 2020 •
edited
Loading

Closes #1

What happened

  • Added alias for lint and coverage
    • Configured credo, sobelow, and excoveralls
  • Add ExMachina for factories
  • Add dialyzer
  • Github actions for PR check
    • Run lint and test

Insight

N/A

Proof Of Work

Coverage Lint
Screen Shot 2020-06-10 at 11 17 00 AM Screen Shot 2020-06-10 at 11 17 25 AM

@Tolsee
Add github action
1e56c42 
Run lint and test as part of the CI test
@olivierobert
Copy link
Contributor

@Tolsee Let's use the newly added Github PR template ✌️

@Tolsee Tolsee added this to the 1.0.0 milestone Jun 10, 2020
@Tolsee Tolsee marked this pull request as ready for review June 10, 2020 04:21
@Tolsee Tolsee changed the title Setup tests Setup test Jun 10, 2020
@Tolsee Tolsee self-assigned this Jun 10, 2020
olivierobert
olivierobert reviewed Jun 10, 2020
View reviewed changes
.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
@Tolsee Tolsee mentioned this pull request Jun 22, 2020
Closed
rosle
rosle approved these changes Jul 7, 2020
View reviewed changes
.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
andyduong1920
andyduong1920 reviewed Jul 13, 2020
View reviewed changes
mix.exs Show resolved Hide resolved
mix.exs Show resolved Hide resolved
andyduong1920
andyduong1920 reviewed Jul 13, 2020
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
andyduong1920
andyduong1920 reviewed Jul 13, 2020
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
andyduong1920
andyduong1920 reviewed Aug 10, 2020
View reviewed changes
.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
lib/nimble_web/router.ex Show resolved Hide resolved
@andyduong1920 andyduong1920 merged commit d1d81c9 into develop Aug 20, 2020
@andyduong1920 andyduong1920 deleted the feature/ts-setup-test branch January 4, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert left review comments

@rosle rosle rosle approved these changes

@andyduong1920 andyduong1920 andyduong1920 approved these changes

Assignees

@Tolsee Tolsee

Labels
type : feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Setup test
4 participants
@Tolsee @olivierobert @rosle @andyduong1920