-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bejzik Updates #1 #239
Bejzik Updates #1 #239
Conversation
@bejzik8 is attempting to deploy a commit to the nimi-app Team on Vercel. To accomplish this, @bejzik8 needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks better, but we still want to keep Nimi Connect in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the cleanup! Looks much better now left some small comments
</HashRouter> | ||
</ThemeProvider> | ||
</ReduxStoreProvider> | ||
<ReduxProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the redux provider since we don't use it...And all the redux related stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we safe to remove Redux, @adamazad? I haven't got to that part yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we safe to remove Redux, @adamazad? I haven't got to that part yet...
Yes, we don't need it at the moment.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summary
First in a row of the upcoming updates series in order to improve
Nimi
's structure, stability, readability, maintainability and scalability.Updates
I am starting with the root component, App. Next is done:
HashRouter
createBrowserRouter
as per documentation by RRD v6Wagmi
setup as per documentationuseRainbow
hookuseENSMetadata
hook🍀