Fixed visual bug with overflown scroll mask #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
After some experimentation, it turns out the fix is to instead only apply the centering logic for big screens starting at 2070px, as otherwise a gap is created between 2000-2070px on the right of the address column (as the width is lower than the screen width). With this fix, all columns grow at the 2000px breakpoint, while the address column still adjusts to the available screen width (because its width is clamped), until 2070px, where it stays centered.
sisou
added a commit
that referenced
this pull request
Mar 2, 2022
* fixed visual bug with overflown scroll mask #93 * Fix gap on right side between 2000-2070 px Co-Authored-By: sisou <hello@soerenschwert.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #93.
This solution has hardcoded values which are highly discouraged, but the rest of the layout is also hardcoded, so I though it wouldn't be a problem.
I can look for another solution if necessary. 😄