free-mujoco-py on PyPi with included binaries
#1
+446
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
download_mujoco.sh
Outdated
| && rm mujoco.tar.gz | ||
|
|
||
| mkdir -p mujoco_py/binaries/windows \ | ||
| && wget https://mujoco.org/download/mujoco210-windows-x86_64.zip -O mujoco.tar.gz \ |
There was a problem hiding this comment.
Windows file is zip rather than tar.gz.
There was a problem hiding this comment.
Thanks for the catch! Just fixed. I will see if I can make the build work on macos
There was a problem hiding this comment.
"Windows support has been DEPRECATED and removed in 2.0.2.0" according to mujoco-py readme...
There was a problem hiding this comment.
Yeah I don’t have a convenient way to test it out on windows and intel mac…
|
I did a quick investigation into the macos build using my m1 mac mini. A couple thing is I needed to install gcc@7 using the rosetta 2 shell (openai#601). I ended up getting this error similar to openai#605. But maybe this is gonna work for intel macs. In any case, probably waiting for upstream changes (google-deepmind/mujoco#2) |
… into include-binaries
|
Apologies I didn't get to review this change - I didn't think mujoco-py were going to accept my PR. I guess you could send this directly to the mujoco-py project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with the transition and offer alternatives, I have made a temporary mujoco-py release named
free-mujoco-pyon PyPi using @nimrod-gileadi's PR (see openai#640) that leverages the new free MuJoCo binaries. Try executingThe source code is at #1. For convenience, the release automatically includes the MuJoCo binaries so there's no need to download it. At this point, it should only work with Linux, but could work out-of-the-box for Mac and maybe windows, I just don't have the machines to test it out.