Skip to content

Commit

Permalink
Use cowlib master
Browse files Browse the repository at this point in the history
  • Loading branch information
essen committed Feb 3, 2015
1 parent 41ac668 commit 3cede06
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 11 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ PLT_APPS = crypto public_key ssl
# Dependencies.

DEPS = cowlib ranch
dep_cowlib = git https://github.com/ninenines/cowlib master

TEST_DEPS = ct_helper gun
dep_ct_helper = git https://github.com/extend/ct_helper.git master

Expand Down
16 changes: 7 additions & 9 deletions src/cowboy_protocol.erl
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
}).

-include_lib("cowlib/include/cow_inline.hrl").
-include_lib("cowlib/include/cow_parse.hrl").

%% API.

Expand Down Expand Up @@ -264,13 +265,12 @@ match_colon(<< _, Rest/bits >>, N) ->
match_colon(_, _) ->
nomatch.

parse_hd_name(<< $:, Rest/bits >>, S, M, P, Q, V, H, SoFar) ->
parse_hd_before_value(Rest, S, M, P, Q, V, H, SoFar);
parse_hd_name(<< C, Rest/bits >>, S, M, P, Q, V, H, SoFar) when ?IS_WS(C) ->
parse_hd_name_ws(Rest, S, M, P, Q, V, H, SoFar);
parse_hd_name(<< C, Rest/bits >>, S, M, P, Q, V, H, SoFar) ->
case C of
$: -> parse_hd_before_value(Rest, S, M, P, Q, V, H, SoFar);
$\s -> parse_hd_name_ws(Rest, S, M, P, Q, V, H, SoFar);
$\t -> parse_hd_name_ws(Rest, S, M, P, Q, V, H, SoFar);
?INLINE_LOWERCASE(parse_hd_name, Rest, S, M, P, Q, V, H, SoFar)
end.
?LOWER(parse_hd_name, Rest, S, M, P, Q, V, H, SoFar).

parse_hd_name_ws(<< C, Rest/bits >>, S, M, P, Q, V, H, Name) ->
case C of
Expand Down Expand Up @@ -429,9 +429,7 @@ parse_host(<< $:, Rest/bits >>, false, Acc) ->
parse_host(<< $], Rest/bits >>, true, Acc) ->
parse_host(Rest, false, << Acc/binary, $] >>);
parse_host(<< C, Rest/bits >>, E, Acc) ->
case C of
?INLINE_LOWERCASE(parse_host, Rest, E, Acc)
end.
?LOWER(parse_host, Rest, E, Acc).

%% End of request parsing.
%%
Expand Down
2 changes: 2 additions & 0 deletions src/cowboy_req.erl
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,8 @@ maybe_reply(Stacktrace, Req) ->
ok
end.

do_maybe_reply([{erlang, binary_to_integer, _, _}, {cow_http_hd, parse_content_length, _, _}|_], Req) ->
cowboy_req:reply(400, Req);
do_maybe_reply([{cow_http_hd, _, _, _}|_], Req) ->
cowboy_req:reply(400, Req);
do_maybe_reply(_, Req) ->
Expand Down
2 changes: 1 addition & 1 deletion src/cowboy_spdy.erl
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ delete_child(Pid, State=#state{children=Children}) ->
-> ok.
request_init(FakeSocket, Peer, OnResponse,
Env, Middlewares, Method, Host, Path, Version, Headers) ->
{Host2, Port} = cow_http:parse_fullhost(Host),
{Host2, Port} = cow_http_hd:parse_host(Host),
{Path2, Qs} = cow_http:parse_fullpath(Path),
Version2 = cow_http:parse_version(Version),
Req = cowboy_req:new(FakeSocket, ?MODULE, Peer,
Expand Down
2 changes: 1 addition & 1 deletion test/handlers/input_crash_h.erl
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
-export([init/2]).

init(Req, content_length) ->
cowboy_error_h:ignore(cow_http_hd, number, 2),
cowboy_error_h:ignore(erlang, binary_to_integer, 1),
cowboy_req:parse_header(<<"content-length">>, Req).

0 comments on commit 3cede06

Please sign in to comment.