Support "208 Already Reported" #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, after looking further into what webdav is, I'm not sure it makes sense to add this anymore. I'll close this PR for now. Feel free to reopen the PR if you would like to discuss this further. |
|
It does because Cowboy has most WebDAV codes already. But this also needs a test added to Cowboy, and it would probably be better to check that all registered codes are available. I will open a separate ticket to double check. |
|
In that case, feel free to merge or to work on top of this PR 🙂 |
|
There was one more missing, I've added it locally and will push soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow developers to use the integer shorthand for status code 208, for example in
cowboy_req:reply/3.The status code is defined in RFC 5842 §7.1.