Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hardcoded -arch x86_64 for MacOS nifs #937

Closed
wants to merge 1 commit into from

Conversation

dominicletz
Copy link
Contributor

Just checked git blame and this flag seems to have been there from the very beginning (powerpc remenant?). For current macs the flag seems problematic as it overrides the default choice of building for the current architecture and hence prevents building on ARM based macs.

Just checked git blame and this flag seems to have been there from the very beginning (powerpc remenant?). For current macs the flag seems problematic as it overrides the default choice of building for the current architecture and hence prevents building on ARM based macs.
@dominicletz
Copy link
Contributor Author

Another thought on this: Even more convenient might be a check for the arch of the OTP system in $PATH to ensure the resulting NIFs are always compatible with that. E.g. with Rosetta2 an ARM user can install and use an intel based OTP build, and might even use that for building. -- Not sure though atm how to best get the right arch flags from erl...

@essen
Copy link
Member

essen commented Oct 19, 2021

But would that be a common scenario? If not, don't worry about it for now. I'll try to get to your PRs soon but I am crunching on something at the moment so it might take a week or two.

@essen
Copy link
Member

essen commented Aug 16, 2022

I will get to this when I am back at work. @lhoguin

@essen
Copy link
Member

essen commented Aug 30, 2022

Merged, thanks!

@essen essen closed this Aug 30, 2022
@dominicletz dominicletz deleted the patch-1 branch August 30, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants