Should include port in host header

[woahdae]

Per section 14.23 of the HTTP spec, gun should include the port along with the hostname in the host header.

the request function in gun_http.erl should have line 196 and line 210 read something like:

false ->
    HostWithPort =
        case Port of
            undefined -> Host;
            80 -> Host;
            _ -> lists:concat(Host, ":", Port)
        end,
    [{<<"host">>, HostWithPort}|Headers2]`

Then you'd have to pass in the port from the main gun loop and change the other protocol request callback methods to match.

I didn't do this because the workaround is just to specify the host header yourself, there isn't a test suite, and I wasn't sure if someone had other opinions. I'm willing to submit some actual code if that's desired, though.

FYI, this is causing issues when we use gun to test a cowboy server, and cowboy uses the host header (apparently) to determine the port, thus passing an incorrect port number (80 instead of 8080).

[essen]

Sounds like an oversight. Yes send a patch! Thanks.

Loïc Hoguin
http://ninenines.eu

-------- Original Message --------
From:Woody Peterson notifications@github.com
Sent:Wed, 27 Aug 2014 05:41:28 +0300
To:extend/gun gun@noreply.github.com
Subject:[gun] Should include port in host header (#28)

Per section 14.23 of the HTTP spec, gun should include the port along with the hostname in the host header.

the request function in gun_http.erl should have line 196 and line 210 read something like:

false -> HostWithPort = case Port of undefined -> Host; 80 -> Host; _ -> lists:concat(Host, ":", Bar) end, [{<<"host">>, HostWithPort}|Headers2]`

Then you'd have to pass in the port from the main gun loop and change the other protocol request callback methods to match.

I didn't do this because the workaround is just to specify the host header yourself, there isn't a test suite, and I wasn't sure if someone had other opinions. I'm willing to submit some actual code if that's desired, though.

—
Reply to this email directly or view it on GitHub.

[woahdae]

Wish I could/knew how to attach a pull request to an existing issue.

Anyways, see #29 for the code.

[essen]

Well I prefer them to be separate. :-) I'll look soon, thanks.

[essen]

Done.