-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow keepalive option in ranch_tcp and ranch_ssl transports #109
Conversation
Alphabetical order on the list of options (at all 4 places you changed), thanks! |
done :) |
Cool. Make that a single commit (git rebase -i HEAD^^^) and squash the right commit and it'll be merged as soon as Monday. |
I don't have objections but you should probably send a PR directly. :-) |
I was about to when I came across this issue, and I figured my PR would have a merge conflict with this one. Would you consider a PR that changes socket option filtering to use a black-list rather than a white-list? I've ran into this issue a couple of times: first with the 'packet' option and then with 'keep-alive' (both of which shouldn't concern the listener socket, and I now set from my handler's init/4), and now with 'ipv6_v6only' (which cannot be set/changed after listen/2). I understand that some setting would interfere with the operation of the listener/acceptor logic in ranch, but it should be possible to filter out those. Maybe for v2? |
Yes, sorry been distracted with erlang.mk, it will be merged as soon as I'm done. |
related to #108