Add post-listen callback #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
essen
reviewed
Aug 27, 2021
juhlig
force-pushed
the
post_listen_callback
branch
from
08b8ac5
to
b9c12c4
Compare
|
Both done in last commit |
|
Missing agent will run whenever it's done with its backlog and then we can merge this I think. |
|
We should document it with an example that shows setting file permissions specifically. |
Tomorrow :) |
juhlig
force-pushed
the
post_listen_callback
branch
from
b9c12c4
to
4687f74
Compare
|
Docs added, please review. |
essen
approved these changes
Sep 1, 2021
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Alternative to #321)
This PR introduces a new transport option
post_listenwhich takes afunof arity 1. This function is called when the listen socket has been created and is given this socket as single argument. The function can then perform any necessary further setup steps on the socket (eg, changing the file permissions of a local socket, as requested in #320). It must return eitherokor{error, Reason}.