Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fail_if_no_peer_cert SSL server option. #34

Closed
wants to merge 2 commits into from
Closed

Support for fail_if_no_peer_cert SSL server option. #34

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2013

SSL option verify alone does not gives full security. Client could send empty certificate and happily access your inner API.

Support for fail_if_no_peer_cert SSL server option.
@essen
Copy link
Member

essen commented Feb 11, 2013

Options in alphabetical order please.

@ghost
Copy link
Author

ghost commented Feb 12, 2013

OK, I'll do.
But, in the first place, is ranch:filter_options really needed in ranch_ssl:listen?
Why not pass all Opts directly to ssl:listen?
All ssl server options are well known and documented: http://www.erlang.org/doc/man/ssl.html.
When passing unsupported option programmer will get nice and clear exception exit: badarg.
Is there ssl server option undesirable/unsupported by ranch?

@essen
Copy link
Member

essen commented Feb 14, 2013

Please squash the commits into one and I will merge it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant