Init nin project #1
Conversation
| @@ -0,0 +1,2 @@ | |||
| gen | |||
There was a problem hiding this comment.
I usually add a / at the end here to show that they are folders. Not sure what's preferred.
| <html> | ||
| <head> | ||
| <meta charset=utf8> | ||
| NIN_WILL_REPLACE_THIS_TAG_WITH_AUTOGENERATED_COMMENT_TAGS |
There was a problem hiding this comment.
Should we manually change this?
There was a problem hiding this comment.
This should be kept like it stands. nin will automatically replace it with values from nin.json on compile time.
index.html
Outdated
| <head> | ||
| <meta charset=utf8> | ||
| NIN_WILL_REPLACE_THIS_TAG_WITH_AUTOGENERATED_COMMENT_TAGS | ||
| <title>My project</title> |
There was a problem hiding this comment.
I say change this to re while we're at it.
There was a problem hiding this comment.
I'm surprised that didn't happen automatically seeing as the command I ran was nin new re
| m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) | ||
| })(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
|
|
||
| ga('create', 'NIN_WILL_REPLACE_THIS_TAG_WITH_YOUR_ANALYTICS_ID', 'auto'); |
There was a problem hiding this comment.
Feel free to create that.
There was a problem hiding this comment.
It's a bit hairy before the demo is live on the internet somewhere. I'll create an issue for now.
There was a problem hiding this comment.
It shouldn't be more complicated than to create a ga property and copy the code here, but I agree just creating an issue for it now is more than good enough.
| "subdivision": 4 | ||
| }, | ||
| "googleAnalyticsID": "Your GA ID" | ||
| } |
There was a problem hiding this comment.
Need newline (if this was autogenerated by nin we need to fix that!)
There was a problem hiding this comment.
Yeah, when generating json files you need to manually add a \n to the end. Easy to forget, should be fixed in nin. Please create an issue for it.
There was a problem hiding this comment.
Did create an issue here ninjadev/nin#320.
| "bpm": 125, | ||
| "subdivision": 4 | ||
| }, | ||
| "googleAnalyticsID": "Your GA ID" |
There was a problem hiding this comment.
We could set this to empty string instead, and have nin compile complain if it is unset, so it's harder to forget.
| <a id=start-button class=hide href=javascript:; onclick=STARTDEMO();> | ||
| START | ||
| </a> | ||
| <a href="http://www.pouet.net/groups.php?which=11702" target="_blank" id="pouet-link">Read more about this demo on Pouet</a> |
There was a problem hiding this comment.
This thing in the template is also easy to forget to change when it's set up like this. Maybe move to nin.json
|
ping |
No description provided.