fix: fix sinon related build erros

ninoseki · Nov 24, 2018 · 8634e71 · 8634e71
1 parent 081e845
commit 8634e71
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/spec/backgroud.spec.ts b/src/spec/backgroud.spec.ts
@@ -1,6 +1,6 @@
 import { expect } from "chai";
 import "mocha";
-import * as sinon from "sinon";
+import sinon = require("sinon");
 import SinonChrome = require("sinon-chrome");
 import * as root from "window-or-global";
 
@@ -57,10 +57,11 @@ describe("Background script", () => {
           },
         });
         const command = new Command("Scan https://www.wikipedia.org/ as a url on Urlscan");
-        sinon.stub(command, "scan").withArgs({
+        const stub: sinon.SinonStub = sinon.stub(command, "scan").withArgs({
           urlscanApiKey: "test",
           virusTotalApiKey: "test",
-        }).returns("https://urlscan.io/entry/ac04bc14-4efe-439d-b356-8384843daf75/");
+        });
+        stub.returns("https://urlscan.io/entry/ac04bc14-4efe-439d-b356-8384843daf75/");
 
         expect(root.chrome.tabs.create.notCalled).to.be.true;
         await scan(command);

diff --git a/src/spec/options.spec.ts b/src/spec/options.spec.ts
@@ -1,7 +1,7 @@
 import { expect } from "chai";
 import { JSDOM } from "jsdom";
 import "mocha";
-import * as sinon from "sinon";
+import sinon = require("sinon");
 import SinonChrome = require("sinon-chrome");
 import * as root from "window-or-global";
 
@@ -28,7 +28,7 @@ describe("Options script", () => {
       const input = root.document.createElement("input") as HTMLInputElement;
       input.value = "test";
 
-      const stub = sinon.stub(root.document, "getElementById");
+      const stub: sinon.SinonStub = sinon.stub(root.document, "getElementById");
       stub.withArgs("urlscan-api-key").returns(input);
       stub.withArgs("virustotal-api-key").returns(input);
     });
@@ -63,7 +63,7 @@ describe("Options script", () => {
       element.appendChild(radio1);
       element.appendChild(radio2);
 
-      const stub = sinon.stub(root.document, "getElementById");
+      const stub: sinon.SinonStub = sinon.stub(root.document, "getElementById");
       stub.withArgs("searcherList").returns(element);
     });
     afterEach(() => {
@@ -90,7 +90,7 @@ describe("Options script", () => {
       const virusTotalApiKey = root.document.createElement("input") as HTMLInputElement;
       virusTotalApiKey.value = "test";
 
-      const stub = sinon.stub(root.document, "getElementById");
+      const stub: sinon.SinonStub = sinon.stub(root.document, "getElementById");
       stub.withArgs("urlscan-api-key").returns(urlscanApiKey);
       stub.withArgs("virustotal-api-key").returns(virusTotalApiKey);
     });
@@ -119,10 +119,10 @@ describe("Options script", () => {
       const dom = new JSDOM();
       root.document = dom.window.document;
 
-      const searcherList = root.document.createElement("div") as HTMLElement; ;
+      const searcherList = root.document.createElement("div") as HTMLElement;;
       searcherList.id = "searcherList";
 
-      const stub = sinon.stub(root.document, "getElementById");
+      const stub: sinon.SinonStub = sinon.stub(root.document, "getElementById");
       stub.withArgs("searcherList").returns(searcherList);
       stub.withArgs("checkTemplate").returns({
         innerHTML: `