Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIO-1125, adding block messages #136

Merged
merged 1 commit into from
Jun 13, 2018
Merged

NIO-1125, adding block messages #136

merged 1 commit into from
Jun 13, 2018

Conversation

f1401martin
Copy link
Contributor

@mattdodge I changed the implementation to match the results you expected in the first place

{
    "status": "started, warning",
    "pid": 98403,
    "parent_pid": 98397,
    "full_status": {
        "service": "started",
        "blocks": {
            "my_logger": {
                "status": "started"
            },
            "my_sub": {
                "status": "started, warning",
                "warning": "Block is not connected"
            },
            "my_pub": {
                "status": "started, warning",
                "warning": "Block is not connected"
            },
            "ee49544c-cdf7-48ad-9780-2ae9653c8d23": {
                "status": "started"
            }
        }
    }
}

the only thing I find with this approach is that calling API would have to "parse" to find out if a message is returned, is that too weird? (Note: I have a different branch with a different implementation, it is more elaborate and returns a more verbose result...)

@mattdodge mattdodge merged commit d888d9a into master Jun 13, 2018
@mattdodge mattdodge deleted the block_messages branch June 13, 2018 16:53
@tlugger tlugger added the change/added a new feature label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change/added a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants