Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultithreadFix: slight FPS boost via multithread improvements #255

Merged
merged 2 commits into from Nov 19, 2022

Conversation

emoose
Copy link
Collaborator

@emoose emoose commented Jul 7, 2022

As mentioned at #44, this removes D3DCREATE_MULTITHREADED safety flag for a slight FPS improvement, and adds some fixes for deadlocks caused by flag being removed.

A MultithreadFix option is added to [DISPLAY] section of INI to toggle it, haven't added GUI stuff for the setting yet though.

This seems to boost FPS by +40-60 for me when running with framelimiter removed, so hopefully will help with FPS drops when playing normally too.

Haven't tested it that much yet though, would appreciate anyone giving it a try! If you get any crashes/hangs please let me know. (maybe create a CrashDumps folder next to bio4.exe first before testing it)

You can grab release build from https://github.com/nipkownix/re4_tweaks/suites/7489522135/artifacts/307461430 - just make sure to edit dinput8.ini and set MultithreadFix to true first.

@nipkownix
Copy link
Owner

Latest test build here:

https://github.com/nipkownix/re4_tweaks/suites/7489522135/artifacts/307461430

@nipkownix
Copy link
Owner

nipkownix commented Sep 22, 2022

Been testing this a bit more lately and haven't had any weird stuff happen so far.
Looks like we're not getting much more people interested in testing as well, sadly.
I'll probably rebase this onto current master (after the trainer merge?) and send a test build to albert. Hopefully he can have some of his testers play with it as well, so we can merge it soon.
A new release approaches :p

This was referenced Nov 11, 2022
@emoose
Copy link
Collaborator Author

emoose commented Nov 19, 2022

Rebased onto latest master, build is up at https://github.com/nipkownix/re4_tweaks/suites/9400765838/artifacts/443597531.

For me this lets r101 go from ~220FPS when looking at village, up to ~250-260FPS
While moving camera to the side (copying the radio call anim) went from ~800FPS to ~950FPS.
Not as big an improvement as dxvk, but still an improvement overall, maybe if it tests as stable enough we could let it be the default for d3d9 users.

@emoose emoose mentioned this pull request Nov 19, 2022
Moved to framerate section since that what it mostly affects (similar to the "EnableFastMath" option which is already there)
@nipkownix
Copy link
Owner

Many thanks once again!

@nipkownix nipkownix merged commit 7872c20 into nipkownix:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants