Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deal with multi-echo indigestion #928

Closed
oesteban opened this issue Jan 10, 2018 · 9 comments
Closed

[BUG] Deal with multi-echo indigestion #928

oesteban opened this issue Jan 10, 2018 · 9 comments
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented Jan 10, 2018

Currently, fmriprep chokes with multi-echo datasets like ds000216:

Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/multiprocessing/process.py", line 249, in _bootstrap
self.run()
File "/usr/local/miniconda/lib/python3.6/multiprocessing/process.py", line 93, in run
self._target(*self._args, **self._kwargs)
File "/usr/local/miniconda/lib/python3.6/site-packages/fmriprep/cli/run.py", line 450, in build_workflow
ignore_aroma_err=opts.ignore_aroma_denoising_errors,
File "/usr/local/miniconda/lib/python3.6/site-packages/fmriprep/workflows/base.py", line 193, in init_fmriprep_wf
ignore_aroma_err=ignore_aroma_err)
File "/usr/local/miniconda/lib/python3.6/site-packages/fmriprep/workflows/base.py", line 461, in init_single_subject_wf
'inputnode.t1_2_fsnative_reverse_transform')]),
File "/usr/local/miniconda/lib/python3.6/site-packages/niworkflows/nipype/pipeline/engine/workflows.py", line 166, in connect
self._check_nodes(newnodes)
File "/usr/local/miniconda/lib/python3.6/site-packages/niworkflows/nipype/pipeline/engine/workflows.py", line 699, in _check_nodes
raise IOError('Duplicate node name "%s" found.' % node.name)
OSError: Duplicate node name "func_preproc_task_rest_wf" found.

This is derived from the fact that bold runs cannot be fully identified with only the task field:

ds000216]$ find sub-01 -name "*_bold.nii.gz"
./sub-01/func/sub-01_task-rest_echo-1_bold.nii.gz
./sub-01/func/sub-01_task-rest_echo-2_bold.nii.gz
./sub-01/func/sub-01_task-rest_echo-3_bold.nii.gz
./sub-01/func/sub-01_task-rest_echo-4_bold.nii.gz

This will probably be solved with the #921 refinement over #884. Is this right, @emdupre?

@emdupre
Copy link
Collaborator

emdupre commented Jan 10, 2018

Yes, that should be handled with #921 and #891 ! Sorry for the hiccup, here.

@oesteban
Copy link
Member Author

oesteban commented Jan 10, 2018

Actually, this problem was present before #891. It's a design problem of fmriprep.

@chrisfilo: before multi-echo support is completely merged, how we should process these images? Each echo independently? (or break with a particular error message)?

@emdupre
Copy link
Collaborator

emdupre commented Jan 10, 2018 via email

oesteban added a commit to oesteban/fmriprep that referenced this issue Jan 10, 2018
Do not group echoes in multi-echo datasets so that each echo is processed
separately (while we work on nipreps#921 for a long-term solution)

Fixes nipreps#928
@oesteban oesteban added this to the 1.1.0 milestone Jan 10, 2018
@emdupre
Copy link
Collaborator

emdupre commented Jan 11, 2018

So I actually am unclear about dfs000216, running it through FMRIPREP. Looking at sub-01, it seems as though the acq files and the echo files are identical. Is there a reason the same data is included twice?

@emdupre
Copy link
Collaborator

emdupre commented Jan 11, 2018

As a follow-up, I'm a little confused as to the BIDS filename convention for this dataset. The acq- keyword has no associated label, which is confusing the grouping scheme I suggested in #921. @chrisfilo, if you have any insight on this I'd be grateful!

@chrisgorgo
Copy link
Contributor

I think I must be lacking some context. What do you mean by "acq- keyword has no associated label"?

To answer @oesteban question. I think it would make sense to treat each echo independently until the MEICA functionality is merged (which will use them together). Let me know if this works for you @emdupre.

@emdupre
Copy link
Collaborator

emdupre commented Jan 11, 2018 via email

@chrisgorgo
Copy link
Contributor

This seems to be an issue with datalad (@yarikoptic). I only see 4 scans on OpenfMRI https://openfmri.org/s3-browser/?prefix=ds000216/ds000216_R1.0.1/uncompressed/sub-01/func/

@emdupre
Copy link
Collaborator

emdupre commented Jan 12, 2018

I opened an issue at datalad/datalad#2069 which @yarikoptic addressed with stunning efficiency. Thank you !!

@oesteban, with #921 and #891 I'm able to run FMRIPREP with no errors-- the report it generates is linked here: https://www.dropbox.com/sh/ip6xpd6oc5awnbm/AADp92KIKev9h6Yb8fIZsYu7a?dl=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants