[FIX] Explicitly pass bold mask to AROMA #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ds005 is failing because of an issue fixed in #1330. Can you update to upstream/master?. Could you also recall to edit the commit message, and include Sorry for the delay. |
…oma and merge with upstream
jdkent
force-pushed
the
add_aroma_mask
branch
from
079bee5
to
235aa1c
Compare
oesteban
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Fixes #1331
Documentation that should be reviewed
The documentation pertaining to ICA-AROMA? I thought a specific mask was always being used, but after digging into the issue, this assumption does not appear to hold.