Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Back port CircleCI configuration from dev branch #2456

Merged
merged 3 commits into from
Jul 19, 2021

Conversation

oesteban
Copy link
Member

  • Addresses issues when authenticating docker hub
  • Updates CircleCI's machine image, and related changes.

Resolves: #2455.

- Addresses issues when authenticating docker hub
- Updates CircleCI's machine image, and related changes.

Resolves: #2455.
@oesteban
Copy link
Member Author

Any obvious caveat or issue that I'm not seeing?

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent some small comments, but overall this looks fine.

@oesteban oesteban merged commit bdcc763 into maint/20.2.x Jul 19, 2021
@oesteban oesteban deleted the maint/2455 branch July 19, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back port docker auth to maint/20.2.x in Circleci
2 participants