-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Optimize build job on CircleCI #2605
Conversation
Looks like it's getting pulled anyway.
I wonder if using the hash in the COPY --from=nipreps/miniconda@sha256:4d0dc0fabb794e9fe22ee468ae5f86c2c8c2b4cd9d7b7fdf0c134d9e13838729 /opt/conda /opt/conda |
It seems the miniconda image might need to be pulled down again - anyways that is probably faster than caching. |
We cross-posted - let me try the digest idea. |
Hmm. No difference. |
I would have expected that. I need to send an empty commit and force a rebuild to be sure it's not going to pick the cached layer. |
Surprisingly, the cache size of this branch is 7.1 GiB, while the |
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
=======================================
Coverage 45.80% 45.80%
=======================================
Files 41 41
Lines 3133 3133
=======================================
Hits 1435 1435
Misses 1698 1698 Continue to review full report at Codecov.
|
Okay, it seems the docker image is always pulled - but it is still faster than caching it so let's merge. We are back down to ~18min for the build job. I think that, creating minimized images for FSL, FreeSurfer and AFNI will substantially reduce build time - even if we have to download or cache these images. |
Pulling miniconda is a waste of time for most Circle builds, since it will only be necessary when that particular step of the docker build needs to be re-executed.