Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Plot carpetplot with CIFTI-specific colorbar #2737

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Mar 6, 2022

The final integration of the edge mask had missed that detail. It went undetected as the reports on Circle did not show CIFTI outputs. Now that is resolved and this PR should conclude the carpet refactor.

Changes proposed in this pull request

Documentation that should be reviewed

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #2737 (9e6c2d5) into master (b6f8dbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2737   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files          44       44           
  Lines        3325     3325           
=======================================
  Hits         1533     1533           
  Misses       1792     1792           
Impacted Files Coverage Δ
fmriprep/interfaces/confounds.py 64.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f8dbd...9e6c2d5. Read the comment docs.

@oesteban oesteban merged commit e476163 into master Mar 6, 2022
@oesteban oesteban deleted the fix/carpet-cifti-colors branch March 6, 2022 19:30
@effigies effigies added this to the 22.0.0 milestone Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants