Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Save T2starmap files in all requested output spaces, if calculated #2776

Merged
merged 8 commits into from
May 13, 2022
Merged

ENH: Save T2starmap files in all requested output spaces, if calculated #2776

merged 8 commits into from
May 13, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented May 9, 2022

Changes proposed in this pull request

Resample T2* map (calculated in BOLD space) to T1w and standard spaces if requested. Sink any of these as functional derivatives.

Unclear what would happen with fsaverage, so will need to test this case.

Documentation that should be reviewed

Need to update expected outputs.

@pep8speaks
Copy link

pep8speaks commented May 9, 2022 •
edited
Loading

Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-13 20:38:35 UTC

@effigies effigies force-pushed the enh/sink_t2starmaps branch 4 times, most recently from 9616047 to 0e06835 Compare May 9, 2022 23:18
@effigies
Copy link
Member Author

@mgxd Any notion why ds005 and ds054 would be timing out?

@mgxd
Copy link
Collaborator

mgxd commented May 10, 2022

it seems like they are both stuck on bold_std_trans_wf.outputnode, so definitely something there.

@effigies effigies force-pushed the enh/sink_t2starmaps branch 3 times, most recently from 044a9a5 to 7ff054d Compare May 10, 2022 15:19
@effigies effigies force-pushed the enh/sink_t2starmaps branch 4 times, most recently from c38fe87 to 1275314 Compare May 10, 2022 20:45
effigies
effigies commented May 10, 2022
View reviewed changes
.circleci/ds210_outputs.txt Outdated Show resolved Hide resolved
@effigies effigies requested a review from emdupre May 10, 2022 20:48
@effigies
Copy link
Member Author

@mgxd final review?

mgxd
mgxd reviewed May 13, 2022
View reviewed changes
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only thing is we should update the docstring "Inputs/Outputs" if they are being altered

@effigies effigies merged commit 8648d82 into nipreps:master May 13, 2022
@effigies effigies added this to the 22.0.0 milestone May 17, 2022
@effigies effigies deleted the enh/sink_t2starmaps branch August 24, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handwerkerd handwerkerd handwerkerd left review comments

@tsalo tsalo tsalo left review comments

@mgxd mgxd mgxd left review comments

@emdupre emdupre Awaiting requested review from emdupre

Assignees
No one assigned
Labels
derivatives multiecho
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@effigies @pep8speaks @mgxd @handwerkerd @tsalo