Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Reports use the default template from niworkflows, allowing overwrite #419

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 2, 2019

Addresses the problem spotted by @josephmje in nipreps/dmriprep#28 (comment)

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #419 into master will decrease coverage by 5.93%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   59.21%   53.27%   -5.94%     
==========================================
  Files          46       46              
  Lines        5036     5036              
  Branches      683      683              
==========================================
- Hits         2982     2683     -299     
- Misses       2008     2234     +226     
- Partials       46      119      +73
Flag Coverage Δ
#masks ?
#reportlettests ?
#unittests ?
Impacted Files Coverage Δ
niworkflows/reports/core.py 70.55% <50%> (-9.21%) ⬇️
niworkflows/func/util.py 24.65% <0%> (-53.43%) ⬇️
niworkflows/interfaces/fixes.py 41.17% <0%> (-45.1%) ⬇️
niworkflows/engine/workflows.py 26.31% <0%> (-15.79%) ⬇️
niworkflows/interfaces/bids.py 80.15% <0%> (-15.48%) ⬇️
niworkflows/interfaces/utility.py 75.92% <0%> (-12.97%) ⬇️
niworkflows/utils/bids.py 76.25% <0%> (-12.5%) ⬇️
niworkflows/interfaces/itk.py 28.39% <0%> (-10.5%) ⬇️
niworkflows/interfaces/registration.py 51.93% <0%> (-10.31%) ⬇️
niworkflows/interfaces/utils.py 38.24% <0%> (-9.98%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf68b6...ceb8316. Read the comment docs.

@oesteban oesteban merged commit 9a07072 into nipreps:master Nov 3, 2019
@oesteban oesteban deleted the enh/open-report-template branch November 3, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant