FIX: revamp Q'kay interface #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: delete unused files
fix: remove useless comment
fix: display error message when user already exists and ask to reenter a new username
fix: modify the interface so that it displays a list of available folders under /datasets fix: warn user if a dataset already exists fix: warn user if the dataset does not contain html files
…ength as argument
fix: improve visualization of inspection list
enh: add a check that at least one HTML file is present inside the dataset folder
enh: remove the IQMs section from the MRIQC report as we said in the preregistration that raters will not have access to the IQMs fix: simplify the function to modify the MRIQC report, change its name so it reflects better the behavior inside and document it better fix: do not write the individual subject templates in the repo. Pass the modified html content to render_template instead fix: delete code related anonymizing the MRIQC report and dealing with html from two folders as this code is still in development. A separate branch will be dedicated to working on those features in the future.
enh: add debugging output to the log about assigning dataset name when creating it
of dataset where the html files are not directly in the folder but in some subfolders fix: add more output to the log
esavary
approved these changes
Apr 30, 2024
| import random | ||
|
|
||
| import numpy as np | ||
| import os.path as op |
There was a problem hiding this comment.
I think we should transition to Pathlib instead of os and glob, but it's better to address this in a future PR.
|
Actually, I don't have the rights to merge this PR, so feel free to do so. |
4 tasks
Indeed, sorry about that! Now it should be okay for future PRs. I've updated your access rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enh: display informative error messages to the user
enh: verify that there is at least one HTML file in dataset, otherwise prevent dataset addition.
enh: remove IQMs section from MRIQC report
enh: improve the output log
fix: docker-compose so it takes into consideration .env
fix: make a more intuitive interface to add datasets
fix: do not write templates in the repo
fix: fix bugs related to adding new users
fix: improve visualization of inspection list
fix: remove unused imports, unused files, unused variables and variables that refer to absolute user-dependent path
fix: simplifies html report so it does not need the list + the list length as an input
fix: remove uninformative comments
fix: move out of the main functions related to anonymization, dealing with two folders as they don't seem ready for deployment
sty: ruff
Closes #21, #22, #23, #20