Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Log incomplete fieldmaps, rather than erroring #341

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

effigies
Copy link
Member

If a dataset has a PEPolar B0FieldSource where one image is in fmap and the other in dwi, the fieldmap wrangler as called from fMRIPrep will fail because we filter out dwi at indexing time. This shouldn't be a problem (unless somebody for some reason wants to correct their BOLD with a DWI image...), so we should just note that we were unable to construct the fieldmap and move on.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.12 ⚠️

Comparison is base (188bc87) 88.56% compared to head (8173e92) 88.45%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   88.56%   88.45%   -0.12%     
==========================================
  Files          25       25              
  Lines        2082     2087       +5     
  Branches      324      325       +1     
==========================================
+ Hits         1844     1846       +2     
- Misses        197      200       +3     
  Partials       41       41              
Flag Coverage Δ
travis 83.32% <66.66%> (-0.11%) ⬇️
unittests 88.28% <66.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/utils/wrangler.py 93.16% <66.66%> (-2.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies merged commit 177af26 into nipreps:master Mar 16, 2023
@effigies effigies deleted the fix/log_incomplete branch March 16, 2023 16:52
@effigies effigies added this to the 2.4.1 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants