Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add cortical ribbon workflow #322

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 3, 2023

#321 has a lot of style changes and some conflicts with master. I tried to pull out the relevant changes into a single commit.

@madisoth could you test this branch? If you're happy with it, you can force-push it to your branch and we can go from there.

@codecov-commenter
Copy link

Codecov Report

Base: 69.62% // Head: 67.69% // Decreases project coverage by -1.93% ⚠️

Coverage data is based on head (ea33e49) compared to base (188f1d1).
Patch coverage: 95.83% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   69.62%   67.69%   -1.93%     
==========================================
  Files          18       19       +1     
  Lines        1185     1232      +47     
  Branches      202      206       +4     
==========================================
+ Hits          825      834       +9     
- Misses        295      340      +45     
+ Partials       65       58       -7     
Flag Coverage Δ
ds005 58.44% <95.83%> (-1.82%) ⬇️
ds054 48.78% <47.91%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/utils/bids.py 47.00% <ø> (ø)
smriprep/workflows/surfaces.py 80.48% <92.30%> (+3.16%) ⬆️
smriprep/interfaces/workbench.py 100.00% <100.00%> (ø)
smriprep/workflows/anatomical.py 51.53% <100.00%> (+0.29%) ⬆️
smriprep/workflows/outputs.py 63.97% <100.00%> (+0.22%) ⬆️
smriprep/interfaces/surf.py 32.00% <0.00%> (-38.00%) ⬇️
smriprep/interfaces/freesurfer.py 56.43% <0.00%> (-10.90%) ⬇️
smriprep/interfaces/reports.py 86.07% <0.00%> (-6.33%) ⬇️
smriprep/cli/run.py 76.99% <0.00%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants