Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Add smoke tests for main anatomical workflows #390

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

effigies
Copy link
Member

Realized I'd started on this, so finished it off. It's just meant to exercise the workflow building logic.

@effigies effigies mentioned this pull request Nov 20, 2023
4 tasks
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e707a6) 57.52% compared to head (c5ca00f) 76.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #390       +/-   ##
===========================================
+ Coverage   57.52%   76.90%   +19.38%     
===========================================
  Files          27       28        +1     
  Lines        1961     2035       +74     
  Branches      235      239        +4     
===========================================
+ Hits         1128     1565      +437     
+ Misses        778      439      -339     
+ Partials       55       31       -24     
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 46.07% <0.00%> (ø)
pytest 66.48% <100.00%> (+29.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

@mgxd @oesteban The rules call for a review...

@effigies effigies merged commit c7356c3 into nipreps:master Nov 20, 2023
16 checks passed
@effigies effigies deleted the test/smoketest-workflows branch November 20, 2023 23:54
effigies added a commit to nipreps/fmriprep that referenced this pull request Nov 21, 2023
Turns out testing's a good idea. Starting out doing something similar to
nipreps/smriprep#390. Will try to expand the smoke tests upward to
`workflows.bold.base` and `workflows.base`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant