Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: T1w_preproc -> t1w_preproc #399

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Nov 21, 2023

Small fix while writing the smoke tests in #390 turned out to be a typo. The issue was that we weren't using the t1w_buffer as a source for T2w preprocessing, so that if you had a preprocessed T1w image but an unprocessed T2w image, you'd try to grab the T1w from the wrong place. And I typed it wrong, and some of these checks are only found at workflow expansion.

Added workflow expansion to the test to catch this.

Fixes #398.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e46b0e6) 76.94% compared to head (7e2909e) 61.36%.

Additional details and impacted files
@@                Coverage Diff                @@
##           maint/0.13.x     #399       +/-   ##
=================================================
- Coverage         76.94%   61.36%   -15.59%     
=================================================
  Files                28       22        -6     
  Lines              2039     1887      -152     
  Branches            240      240               
=================================================
- Hits               1569     1158      -411     
- Misses              438      701      +263     
+ Partials             32       28        -4     
Flag Coverage Δ
ds005 ?
ds054 ?
pytest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 1fc4622 into nipreps:maint/0.13.x Nov 21, 2023
15 of 17 checks passed
@effigies effigies deleted the fix/connection-typo branch November 21, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants