Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Multiple Language Support #2

Closed
nipunsadvilkar opened this issue Jun 14, 2017 · 6 comments · Fixed by #84
Closed

Adding Multiple Language Support #2

nipunsadvilkar opened this issue Jun 14, 2017 · 6 comments · Fixed by #84
Projects

Comments

@nipunsadvilkar
Copy link
Owner

nipunsadvilkar commented Jun 14, 2017

Add pysbd support for all the languages supported by pragmatic_segmenter

@nipunsadvilkar nipunsadvilkar created this issue from a note in pySBD (To Do) Jun 14, 2017
@zlhcsm
Copy link

zlhcsm commented Oct 27, 2019

Will there be a Chinese version

@nipunsadvilkar
Copy link
Owner Author

@zlhcsm Yes, there will be

@victornoriega
Copy link

What about spanish support?

@nmstoker
Copy link

@nipunsadvilkar what approach are you planning for multi-language support?
I see that Pragmatic Segmenter has coverage for these languages:

https://github.com/diasks2/pragmatic_segmenter/tree/master/spec/pragmatic_segmenter/languages

Were you thinking of porting that over or taking a fresh approach?

Although I don't have significant spoken language skills (besides English!) if there's testing or some other basic task I could help with, I'd be interested in lending a hand

@nipunsadvilkar
Copy link
Owner Author

@nmstoker Thank you for the interest. I've been working adding support for other languages in PR #63 and have refactored the code to port the rest of the languages supported by pragamatic_segmenter into pysbd.

I myself know English, Hindi & Marathi language so adding support in PR #63. Will be updating with other languages in next few days

@nipunsadvilkar nipunsadvilkar pinned this issue Jun 3, 2020
nipunsadvilkar added a commit that referenced this issue Jun 9, 2020
@nipunsadvilkar nipunsadvilkar linked a pull request Nov 27, 2020 that will close this issue
@esalesky
Copy link

Hi! Great to see this port -- what is the current status of porting additional languages beyond English from the ruby version? I saw several languages that I'm interested in in the results from the NLP-OSS paper, but I noticed when testing some of the Japanese and Arabic examples from the ruby version README with the python code that I got different results. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
pySBD
  
To Do
Development

Successfully merging a pull request may close this issue.

5 participants