Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydicom.dcmread() instead of pydicom.read_file() #668

Merged
merged 1 commit into from Apr 12, 2023
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 12, 2023

read_file() was deprecated in pydicom v2.2.0 and will be removed in v3.0. Code should instead use dcmread(), which has been an alias of read_file() since pydicom v1.0.0.

@jwodder jwodder added the internal Changes only affect the internal API label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (2c6d228) 81.48% compared to head (37d5973) 81.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files          41       41           
  Lines        3900     3900           
=======================================
  Hits         3178     3178           
  Misses        722      722           
Impacted Files Coverage Δ
heudiconv/heuristics/multires_7Tbold.py 14.28% <0.00%> (ø)
heudiconv/tests/test_regression.py 93.25% <ø> (ø)
heudiconv/bids.py 90.51% <100.00%> (ø)
heudiconv/dicoms.py 86.10% <100.00%> (ø)
heudiconv/tests/test_dicoms.py 86.04% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit 5e6c7ea into master Apr 12, 2023
14 of 15 checks passed
@yarikoptic yarikoptic deleted the dcmread branch April 12, 2023 16:05
@github-actions
Copy link

github-actions bot commented May 8, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants