ENH: set and expose global dicom compresslevel var #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Apr 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 41 41
Lines 3899 3900 +1
=======================================
+ Hits 3177 3178 +1
Misses 722 722
☔ View full report in Codecov by Sentry. |
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
yarikoptic
reviewed
Apr 29, 2023
| @@ -20,6 +20,9 @@ | |||
|
|
|||
| lgr = logging.getLogger(__name__) | |||
| total_files = 0 | |||
| # Might be monkey patched by user heuristic to tune desired compression level | |||
| # Preferably do not move/rename unless | |||
There was a problem hiding this comment.
Suggested change
| # Preferably do not move/rename unless | |
| # Preferably do not move/rename unless |
There was a problem hiding this comment.
hey github -- where is mergecommit button???
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's tarfile is using a compression level of 9 by default (back to and including python 3.5): https://docs.python.org/3/library/tarfile.html#tarfile.open
We see cases where this leads to a large waste of cpu cycles with minimal gain as opposed to compress level 5 or even 1.
Setting a global
compresslevelvariable makes it easy to override from our heuristics, keeping the default with minimal code impact.