Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not demand --files for all commands, even those which do not care about it (like populate-intended-for) #708

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

yarikoptic
Copy link
Member

It refactors how we do check and assertion now for mypy to stay quiet. Closes #707

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Sep 27, 2023
…are about it

It refactors how we do check and assertion now for mypy to stay quiet.
Closes nipy#707
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a882f73) 82.00% compared to head (40f34b9) 81.95%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   82.00%   81.95%   -0.06%     
==========================================
  Files          41       41              
  Lines        4130     4139       +9     
==========================================
+ Hits         3387     3392       +5     
- Misses        743      747       +4     
Files Coverage Δ
heudiconv/main.py 77.71% <54.54%> (-1.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit aa4c785 into nipy:master Sep 28, 2023
9 of 11 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🚀 PR was released in v1.0.1 🚀

@yarikoptic yarikoptic deleted the bf-no-files branch December 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commandline --command option usage
1 participant