Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #722

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Drop Python 3.7 support #722

merged 4 commits into from
Dec 8, 2023

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 8, 2023

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e259f35) 81.97% compared to head (2e761a5) 81.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          41       41           
  Lines        4149     4149           
=======================================
  Hits         3401     3401           
  Misses        748      748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -i -e 's,3\\.7,3.8,g' .github/workflows/codespell.yml .github/workflows/docker.yml .github/workflows/lint.yml .github/workflows/release.yml .github/workflows/test.yml .github/workflows/typing.yml",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Member Author

@jwodder -- do you have quick clue on why we get older setuptools installed

2023-12-08T22:32:04.1539412Z   × pip subprocess to install build dependencies did not run successfully.
2023-12-08T22:32:04.1540645Z   │ exit code: 2
2023-12-08T22:32:04.1541435Z   ╰─> [110 lines of output]
2023-12-08T22:32:04.1542543Z       Ignoring numpy: markers 'python_version == "3.7"' don't match your environment
2023-12-08T22:32:04.1544530Z       Ignoring numpy: markers 'python_version >= "3.8" and python_version < "3.11"' don't match your environment
2023-12-08T22:32:04.1545934Z       Collecting setuptools==60.5
2023-12-08T22:32:04.1546922Z         Downloading setuptools-60.5.0-py3-none-any.whl (958 kB)
2023-12-08T22:32:04.1548651Z            ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 959.0/959.0 kB 26.6 MB/s eta 0:00:00

so that we get

        File "/tmp/pip-build-env-pb4b294m/overlay/lib/python3.12/site-packages/setuptools/__init__.py", line 10, in <module>
          import distutils.core
      ModuleNotFoundError: No module named 'distutils'

on py 3.12
?

@jwodder
Copy link
Member

jwodder commented Dec 8, 2023

@yarikoptic This is the fault of pylibjpeg-libjpeg. Its build requirements pin setuptools for some reason, but the actual build failure is due to the fact that these requirements specify exactly numpy 1.23.2 on Python 3.11 and above, and that version (which was released over a year ago) requires distutils to install.

@yarikoptic
Copy link
Member Author

Thank you @jwodder for the analysis!!! my humble attempt pydicom/pylibjpeg-libjpeg#48

@yarikoptic
Copy link
Member Author

meanwhile I will just drop attempt at 3.12 here, so we will just end up dropping 3.7

@yarikoptic yarikoptic changed the title Drop Python 3.7 and announce support for 3.12 Drop Python 3.7 support Dec 8, 2023
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Dec 8, 2023
@yarikoptic yarikoptic merged commit 7db9f6c into nipy:master Dec 8, 2023
10 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🚀 PR was released in v1.0.1 🚀

@yarikoptic yarikoptic deleted the enh-3.12 branch December 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants