Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to save FreeSurfer annotation files. #206

Merged
merged 3 commits into from
Oct 7, 2013
Merged

Add function to save FreeSurfer annotation files. #206

merged 3 commits into from
Oct 7, 2013

Conversation

ohinds
Copy link
Contributor

@ohinds ohinds commented Oct 6, 2013

A couple pep8 changes to the io.py file accompany.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 10765e2 on ohinds:save_annot into d744e5e on nipy:master.

@agramfort
Copy link
Contributor

thanks ! can you add a test to make sure writing and reading back is ok? see file test_io.py

@ohinds
Copy link
Contributor Author

ohinds commented Oct 7, 2013

Yup, done.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9cde784 on ohinds:save_annot into d744e5e on nipy:master.

@agramfort
Copy link
Contributor

thanks. Just to check, does it work too when read_annot uses orig_ids=False ?

orig_inds=True after they are written with write_annot.
@ohinds
Copy link
Contributor Author

ohinds commented Oct 7, 2013

It actually only worked with orig_inds=False before. Now it works with both.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4e67dc1 on ohinds:save_annot into d744e5e on nipy:master.

@agramfort
Copy link
Contributor

thanks for the contrib

agramfort added a commit that referenced this pull request Oct 7, 2013
Add function to save FreeSurfer annotation files.
@agramfort agramfort merged commit 31445dc into nipy:master Oct 7, 2013
@ohinds
Copy link
Contributor Author

ohinds commented Oct 7, 2013

Sure thing.

grlee77 pushed a commit to grlee77/nibabel that referenced this pull request Mar 15, 2016
Add function to save FreeSurfer annotation files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants