-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: fast reads on large gzip files #210
Conversation
Acutally use the opening logic
Gael - any progress? |
Man, oh man... It will be at least another 2 weeks with no activity. |
Seriously? Do you want me to finish this up? I don't get to internet much On Mon, Dec 2, 2013 at 4:51 PM, Gael Varoquaux notifications@github.comwrote:
|
On Mon, Dec 02, 2013 at 02:16:26PM -0800, Matthew Brett wrote:
As you wish. I don't mind working on it, but right now I have a lot of G |
Allows user to set max chunk size.
OK - I've done a PR to your branch. Can you review and merge? Then I'll merge with trunk. |
Gael - have you got a few minutes for this? |
@matthew-brett this one seems pretty straightforward... do you want to open a new PR with your branch that has your commit on top of Gael's? I'm happy to review before you merge if you want. |
@matthew-brett and @GaelVaroquaux - what's the status with this PR? i'm running into this with some diffusion data. it takes about 30 mins to read the compressed file. however, in addition to the gzip issue, even uncompressed it takes 6 min to read 4G. this is reading from local disk
|
scratch the above load times - something is wrong with that node. |
MRG: add module global to gzip as discussed
MRG: fast reads on large gzip files Fixes #209
@matthew-brett : I am sorry for going missing in action for so long. I am getting more and more committed with day-to-day management, and thus I have a hard time trying to contribute to projects that I don't know very well. Anyhow, thanks for waiting for me. I feel honored! |
:) |
MRG: fast reads on large gzip files Fixes nipy#209
Fixes #209