MRG: add PARREC to top level load #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
parrec-top-level
branch
from
24bb052
to
50ab6f8
Compare
Make `Opener` class ignore case when looking for compressed extensions such as '.gz' or '.bz2', by default.
Add docstring for filespec_to_file_map class method.
Allow image filenames to be mixed case including compressed extensions like '.gz' and '.bz2'.
Some images (particularly, PARREC), cannot be easily constructed in memory, because their headers are rather complicated to construct. Allow skipping tests that need to construct in-memory images.
Allow PAR/REC files to be loaded from top-level `nibabel.load` function.
matthew-brett
force-pushed
the
parrec-top-level
branch
from
50ab6f8
to
b6f62be
Compare
| @@ -48,10 +48,12 @@ class Opener(object): | |||
| compress_ext_map = { | |||
| '.gz': gz_def, | |||
| '.bz2': bz2_def, | |||
| None: (open, ('mode', 'buffering')) | |||
| None: (open, ('mode', 'buffering')) # default | |||
There was a problem hiding this comment.
If you want to move toward PEP8 (do you?), there should be two spaces before an inline comment
|
LGTM, being able to use |
From comment by Eric Larson
|
Much nicer :) |
matthew-brett
added a commit
that referenced
this pull request
Nov 4, 2014
MRG: add PARREC to top level load Add ability to load PAR / REC file from top-level nibabel.load. On the way, make load function allow upper case compressed extensions, and refactor image class generic testing to allow case where it is difficult to create image class in memory.
|
:) |
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: add PARREC to top level load Add ability to load PAR / REC file from top-level nibabel.load. On the way, make load function allow upper case compressed extensions, and refactor image class generic testing to allow case where it is difficult to create image class in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to load PAR / REC file from top-level
nibabel.load.On the way, make load function allow upper case compressed extensions, and
refactor image class generic testing to allow case where it is difficult to
create image class in memory.