BUG: work round int overflow in size calculation #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
img-size-fix
branch
from
a6bd532
to
3668cb3
Compare
| @@ -504,7 +507,8 @@ def array_from_file(shape, in_dtype, infile, offset=0, order='F', mmap=True): | |||
| pass | |||
| if len(shape) == 0: | |||
| return np.array([]) | |||
| n_bytes = int(np.prod(shape) * in_dtype.itemsize) | |||
| # Use reduce and mul to work round integer overflow on 32-bit platforms | |||
matthew-brett
force-pushed
the
img-size-fix
branch
from
3668cb3
to
e3beee2
Compare
| @@ -504,7 +507,8 @@ def array_from_file(shape, in_dtype, infile, offset=0, order='F', mmap=True): | |||
| pass | |||
| if len(shape) == 0: | |||
| return np.array([]) | |||
| n_bytes = int(np.prod(shape) * in_dtype.itemsize) | |||
There was a problem hiding this comment.
You could also specify the dtype in np.prod, rather than introduce operator.mul:
n_bytes = int(np.prod(shape, dtype=np.int64) * in_dtype.itemsize)
There was a problem hiding this comment.
The advantage of using operator.mul is that is uses Python integers internally, and so completely prevents overflow for any possible value of the shape. In fact the test tests overflow for values above the int64 range, although of course you cannot make an array that large.
There was a problem hiding this comment.
Fair enough. Might change the comment to reflect that it's not just avoiding int32 overflows, but that's really nit-picky.
matthew-brett
force-pushed
the
img-size-fix
branch
from
e3beee2
to
4999e50
Compare
Omar pointed out the integer overflow in calculating the image size of an image of size > 4GB, on a 32-bit platform.
|
OK to merge? |
|
Not sure who are valid signers-off, but it looks reasonable to me. |
larsoner
added a commit
that referenced
this pull request
Jul 9, 2015
BUG: work round int overflow in size calculation
|
Thanks @matthew-brett for the fix |
Closed
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
BUG: work round int overflow in size calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omar pointed out the integer overflow in calculating the image size of an
image of size > 4GB, on a 32-bit platform.