RF: remove roi module pending rewrite #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROI module needs some work and does not have tests. It's in a prominent place, and Bertrand's ROI modules are a better option at the moment. Remove for now, pending proper refactor.
|
I think Yannick has done some work on ROI as well - so yes - sounds good to postpone that |
jbpoline
added a commit
that referenced
this pull request
Jun 5, 2012
RF: remove roi module pending rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROI module needs some work and does not have tests. It's in a
prominent place, and Bertrand's ROI modules are a better option at the
moment. Remove for now, pending proper refactor.