BF: make histogram bins integer for numpy 1.10 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at numpy/numpy#6469, it looks like it was rounding down before. Is this an explicit decision to round up? For consistent behavior across versions, I'd probably use integer division: To compare, another |
Numpy 1.10 seems to need an integer input to np.histogram.
Small edits to smoothed_histogram_from_samples docstring.
matthew-brett
force-pushed
the
numpy-1.10-fix
branch
from
4d61681
to
bf0a6c1
Compare
|
Thanks for looking at this. I made the // change you suggested. The other np.histogram instance you found, I think is passing a vector of bin positions, so these do not have to be integers. |
|
Makes sense. CI error seems unrelated, so LGTM. |
|
Thanks again for the review - in it goes. |
matthew-brett
added a commit
that referenced
this pull request
Oct 14, 2015
MRG: make histogram bins integer for numpy 1.10 Numpy 1.10 seems to need an integer input to np.histogram. Probably fixes gh-369.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 1.10 seems to need an integer input to np.histogram.
Probably fixes gh-369.
I would be happy of a quick review.